Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: Merge GraphCommand and Command #2638

Merged
merged 2 commits into from
Dec 4, 2024
Merged

lib: Merge GraphCommand and Command #2638

merged 2 commits into from
Dec 4, 2024

Conversation

nfcampos
Copy link
Contributor

@nfcampos nfcampos commented Dec 4, 2024 •
edited
Loading

  • Now we have only Command
  • Command(goto=) combines the previous functionality of Command(send=) and GraphCommand(goto=)

@nfcampos
lib: Merge GraphCommand and Command
b4b3ac6 
- Now we have only Command
- Command(goto=) combines the previous functionality of Command(send=) and Command(goto=)
@nfcampos
Lint
df70e91
hinthornw
hinthornw reviewed Dec 4, 2024
View reviewed changes
Copy link
Contributor

@hinthornw hinthornw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice - ya would need the string support to finalize the merge right?

@nfcampos
Copy link
Contributor Author

nfcampos commented Dec 4, 2024

No I can merge before that, and fix in a later pr

@nfcampos nfcampos merged commit dcc2617 into main Dec 4, 2024
59 checks passed
@nfcampos nfcampos deleted the nc/4dec/command branch December 4, 2024 23:26
@tjni tjni mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hinthornw hinthornw hinthornw left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nfcampos @hinthornw